Skip to content

chore: Update Github action resources #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathanedey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Update Github action resources #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .github/resources/firebase.asc.gpg
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion .github/resources/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</activation>
<properties>
<gpg.executable>gpg</gpg.executable>
<gpg.keyname>0A05D8FAD4287A36C53BE07714D6B82AEB1DD39C</gpg.keyname>
<gpg.keyname>40232A3CABB94E75E654F6A973E5C093C01673CB</gpg.keyname>
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better security and maintainability, it's recommended to avoid hardcoding the GPG key name directly in the settings file. Storing it in a GitHub secret and accessing it as an environment variable (e.g., ${env.GPG_KEYNAME}) would be a more robust approach. This allows for easier key rotation and management without requiring code changes.

Suggested change
<gpg.keyname>40232A3CABB94E75E654F6A973E5C093C01673CB</gpg.keyname>
<gpg.keyname>${env.GPG_KEYNAME}</gpg.keyname>

<gpg.passphrase>${env.GPG_PASSPHRASE}</gpg.passphrase>
</properties>
</profile>
Expand Down
Loading