Draft
Conversation
Initial revision for embedded mode documentation.
Contributor
kevin-m-knight-gs
left a comment
kevin-m-knight-gs
left a comment
There was a problem hiding this comment.
I don't think this document actually provides a definition of embedded mode. I would expect a definition of embedded mode to discuss things like project configuration, project structure, what other modes there are, and how embedded mode differs from them. But I do not see any of that.
Most of it seems to be generically about why someone might use Legend. I think you can assume that anyone looking at this document already has this context.
Also, maybe this file should be in a docs directory, rather than at the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial revision for embedded mode documentation.