Replace webpack build in fdc3-conformance with vite#1832
Open
pranitaurlam wants to merge 1 commit intofinos:mainfrom
Open
Replace webpack build in fdc3-conformance with vite#1832pranitaurlam wants to merge 1 commit intofinos:mainfrom
pranitaurlam wants to merge 1 commit intofinos:mainfrom
Conversation
- Remove webpack.config.js and webpack/webpack-cli/ts-loader/css-loader/style-loader deps - Add vite.config.ts with multiple TS entry points (ES module format) - Use vite-plugin-node-polyfills to replace manual Buffer/process/stream polyfills - Use vite-plugin-css-injected-by-js to inline CSS (mirrors webpack style-loader) - Remove node polyfill runtime deps (buffer, process, stream-browserify, util, window) - Convert require() to ES imports in src/test/index.ts - Update all static HTML app pages to use <script type="module"> for ES module output - Remove redundant sourceMapSupport.install() inline script from app/index.html Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
One or more co-authors of this pull request were not found. You must specify co-authors in commit message trailer via: Supported
Alternatively, if the co-author should not be included, remove the Please update your commit message(s) by doing |
kriswest
requested changes
Apr 14, 2026
Contributor
kriswest
left a comment
There was a problem hiding this comment.
@pranitaurlam could you have a look at the conflicts please.
Also please note that you will need to add an entry in CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1830
webpack.config.jswithvite.config.tsintoolbox/fdc3-conformancefdc3-workbench,fdc3-for-web/reference-ui)vite-plugin-node-polyfillsreplaces webpack'sProvidePlugin+ manualresolve.fallbackpolyfillsvite-plugin-css-injected-by-jsreplaces webpack'sstyle-loaderfor CSS injectionbuffer,process,stream-browserify,util,window) since vite-plugin-node-polyfills handles these at build timerequire()calls to ESimportstatements insrc/test/index.ts<script type="module">for ES module outputsourceMapSupport.install()inline script fromapp/index.html(timing issue with deferred modules; source map support is set up by the imported module)Test plan
npm run buildintoolbox/fdc3-conformancecompletes successfully with vitenpm run devstarts the conformance test server on port 3001toolbox/fdc3-for-web/demo)🤖 Generated with Claude Code