Add basic conformance tests for addEventListener#1817
Open
Maximiliano-Zeballos wants to merge 1 commit intofinos:mainfrom
Open
Add basic conformance tests for addEventListener#1817Maximiliano-Zeballos wants to merge 1 commit intofinos:mainfrom
Maximiliano-Zeballos wants to merge 1 commit intofinos:mainfrom
Conversation
❌ Deploy Preview for fdc3 failed. Why did it fail? →
|
|
|
9ee088e to
34a176b
Compare
kriswest
requested changes
Apr 10, 2026
Contributor
kriswest
left a comment
There was a problem hiding this comment.
The test implementations look fine to me - but we need the definitions also added to the standard's docs at https://github.com/Maximiliano-Zeballos/FDC3/blob/feature/add-event-listener-conformance-test/website/docs/api/conformance/Basic-Tests.md
kriswest
requested changes
Apr 14, 2026
Contributor
kriswest
left a comment
There was a problem hiding this comment.
Hi @Maximiliano-Zeballos, many thanks for your contribution. Please note that we'll need you to:
- rebase against main
- Add a description of the new case in the docs at: https://github.com/Maximiliano-Zeballos/FDC3/blob/feature/add-event-listener-conformance-test/website/docs/api/conformance/Basic-Tests.md
- add an entry in CHANGELOG.md describing the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Add basic conformance tests for
addEventListeneras described in #1774.Two tests following the existing pattern used for
addContextListener(BasicCL1/BasicCL2):addEventListeneris callable with a specific event type (userChannelChanged) and returns a validListenerobject with anunsubscribefunction.nullas the event type.Also adds the
addEventListenerdocumentation link toapiDocuments.ts.Related Issue
Resolves #1774
Contributor License Agreement
Review Checklist