Skip to content

Add basic conformance tests for addEventListener#1817

Open
Maximiliano-Zeballos wants to merge 1 commit intofinos:mainfrom
Maximiliano-Zeballos:feature/add-event-listener-conformance-test
Open

Add basic conformance tests for addEventListener#1817
Maximiliano-Zeballos wants to merge 1 commit intofinos:mainfrom
Maximiliano-Zeballos:feature/add-event-listener-conformance-test

Conversation

@Maximiliano-Zeballos
Copy link
Copy Markdown

Describe your change

Add basic conformance tests for addEventListener as described in #1774.

Two tests following the existing pattern used for addContextListener (BasicCL1/BasicCL2):

  • BasicAEL1: Verifies addEventListener is callable with a specific event type (userChannelChanged) and returns a valid Listener object with an unsubscribe function.
  • BasicAEL2: Verifies the same behavior when passing null as the event type.

Also adds the addEventListener documentation link to apiDocuments.ts.

Related Issue

Resolves #1774

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • CHANGELOG: Is a CHANGELOG.md entry included?
  • API changes: Does this PR include changes to any of the FDC3 APIs? — No, only conformance tests.

@Maximiliano-Zeballos Maximiliano-Zeballos requested a review from a team as a code owner April 1, 2026 16:23
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 1, 2026

Deploy Preview for fdc3 failed. Why did it fail? →

Name Link
🔨 Latest commit 34a176b
🔍 Latest deploy log https://app.netlify.com/projects/fdc3/deploys/69cd504da11081000723addc

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 1, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Maximiliano-Zeballos / name: Maximiliano Zeballos (34a176b)

@Maximiliano-Zeballos Maximiliano-Zeballos force-pushed the feature/add-event-listener-conformance-test branch from 9ee088e to 34a176b Compare April 1, 2026 17:05
Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test implementations look fine to me - but we need the definitions also added to the standard's docs at https://github.com/Maximiliano-Zeballos/FDC3/blob/feature/add-event-listener-conformance-test/website/docs/api/conformance/Basic-Tests.md

Copy link
Copy Markdown
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maximiliano-Zeballos, many thanks for your contribution. Please note that we'll need you to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Basic conformance test for addEventListener

2 participants