OpenAPI schema sync (v3.6.0) - #266
Merged
Merged
Conversation
fingerprint-dx-team-actions-runner
Bot
requested review from
Orkuncakilkaya,
TheUnderScorer,
erayaydin and
ilfa
as code owners
August 10, 2026 20:47
Contributor
|
🟢 Coverage increased by 97.53% Code Coverage ReportCoverage Report
Files Coverage
|
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/php-sdk@7.5.0Minor Changes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs the PHP SDK with the Fingerprint Pro Server API OpenAPI schema release v3.6.0 by introducing an Event.source field backed by a new EventSource enum, and updating generated artifacts, docs, mocks, and tests accordingly.
Changes:
- Add
EventSourcebacked enum (device,edge) and wire it intoEventas the newsourcefield. - Update docs, schema YAML, and generator file lists to include the new enum/field.
- Extend unit/API tests and JSON mocks to cover deserialization and ensure
sourceis present in mocked responses.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/Model/EventTest.php | Adds coverage for Event.source deserialization (known/unknown/missing values) and setter behavior. |
| test/Model/EventSourceTest.php | New unit tests for EventSource enum cases, backing values, and serializer deserialization. |
| test/Model/EnumCoverageTest.php | Includes EventSource in the shared enum coverage provider. |
| test/mocks/events/search/get_event_search_200.json | Adds "source": "device" to mocked search response event. |
| test/mocks/events/get_event_with_bot_info_200.json | Adds "source": "device" to mocked event response. |
| test/mocks/events/get_event_ruleset_200.json | Adds "source": "device" to mocked event response. |
| test/mocks/events/get_event_200.json | Adds "source": "device" to mocked event response. |
| test/mocks/events/get_event_200_with_unknown_field.json | Adds "source": "device" to mocked event response. |
| test/Api/FingerprintApiTest.php | Asserts Event.source is deserialized as EventSource::DEVICE in API test helper. |
| src/Model/EventSource.php | Introduces new generated backed enum for event source. |
| src/Model/Event.php | Adds source property metadata plus getSource()/setSource() accessors. |
| res/fingerprint-server-api.yaml | Adds EventSource schema and Event.source property in the OpenAPI spec. |
| README.md | Adds EventSource to the documented model list. |
| docs/Model/EventSource.md | New generated documentation page for the EventSource enum. |
| docs/Model/Event.md | Documents the new optional source field on Event. |
| .schema-version | Bumps synced schema version to v3.6.0. |
| .openapi-generator/FILES | Registers new generated files (EventSource model + docs). |
| .changeset/add-event-source-field.md | Adds a minor changeset describing the new Event.source field. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Orkuncakilkaya
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema sync for v3.6.0 OpenAPI schema release.