Skip to content

test: add active_call filter coverage to searchEventsMaximumParamsTest - #46

Merged
mcnulty-fp merged 1 commit into
feat/open-api-v3.7.0from
copilot/update-search-events-maximum-params-test
Aug 21, 2026
Merged

test: add active_call filter coverage to searchEventsMaximumParamsTest#46
mcnulty-fp merged 1 commit into
feat/open-api-v3.7.0from
copilot/update-search-events-maximum-params-test

Conversation

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

The v3.7.0 schema sync (PR #45) adds a new active_call filter to searchEvents, but searchEventsMaximumParamsTest doesn't exercise it. This extends the "maximum params" test so the new parameter is covered end-to-end.

Changes

  • Input value: add final Boolean ACTIVE_CALL = true;
  • Expected query params: assert active_call is serialized via expectedQueryParams.put("active_call", ...), which also feeds the total param-count check
  • API call: pass .setActiveCall(ACTIVE_CALL) into the searchEvents(...) invocation
final Boolean ACTIVE_CALL = true;
expectedQueryParams.put("active_call", String.valueOf(ACTIVE_CALL));

api.searchEvents(
    new FingerprintApi.SearchEventsOptionalParams()
        // ...existing params...
        .setSource(SOURCE)
        .setActiveCall(ACTIVE_CALL));

Note: this branch is stacked on PR #45's feat/open-api-v3.7.0 (where setActiveCall/active_call are introduced); it should be retargeted to that branch rather than main for review.

Co-authored-by: mcnulty-fp <212590662+mcnulty-fp@users.noreply.github.com>
Copilot AI requested a review from mcnulty-fp August 21, 2026 13:43
@mcnulty-fp
mcnulty-fp changed the base branch from main to feat/open-api-v3.7.0 August 21, 2026 13:46
@mcnulty-fp
mcnulty-fp marked this pull request as ready for review August 21, 2026 14:04
@mcnulty-fp
mcnulty-fp merged commit d8dafe4 into feat/open-api-v3.7.0 Aug 21, 2026
18 of 19 checks passed
@mcnulty-fp
mcnulty-fp deleted the copilot/update-search-events-maximum-params-test branch August 21, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants