OpenAPI schema sync (v3.5.1) - #38
Merged
Merged
Conversation
fingerprint-dx-team-actions-runner
Bot
requested review from
Orkuncakilkaya,
erayaydin,
ilfa,
mcnulty-fp and
necipallef
as code owners
July 31, 2026 15:26
mcnulty-fp
previously approved these changes
Jul 31, 2026
erayaydin
previously approved these changes
Jul 31, 2026
erayaydin
left a comment
erayaydin
left a comment
Member
There was a problem hiding this comment.
LGTM 🚀 🤗
Nit: there are a few extra mock files here; since no new tests were added, I think we can drop/delete them. I don't see a reason for them to be tracked with VCS in the Java SDK.
sdk/src/test/resources/mocks/errors/429_too_many_search_requests.jsonsdk/src/test/resources/mocks/errors/504_search_timeout_exceeded.jsonsdk/src/test/resources/mocks/events/get_event_with_edge_200.json
Contributor
Contributor
Good call! Removed those mocks in 4fc0577 |
erayaydin
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema sync for v3.5.1 OpenAPI schema release.