Zarr New #25
Open
Zarr New #25
+193
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozusznik
requested changes
Apr 21, 2023
| } catch (IOException | ModuleException e) { | ||
| myLogger.error("Some error accessing the reference service and dataset: "+e.getMessage()); | ||
| } catch (ExecutionException e) { | ||
| e.printStackTrace(); |
| @@ -181,6 +181,7 @@ public static void writeN5File(final AbstractSequenceDescription<?, ?, ?> seq, | |||
| int numCompletedTasks = 0; | |||
|
|
|||
| final ExecutorService executorService = Executors.newFixedThreadPool( numCellCreatorThreads ); | |||
| //TODO FIND N5 WRITER AND MAKE HIM CHANGABLE | |||
There was a problem hiding this comment.
It is possible to make TODO before pull request.
|
|
||
| di.compression = this.compression.equals("none") ? "raw" : this.compression; | ||
|
|
||
| //TODO totally random solution |
There was a problem hiding this comment.
Is it still true - it should not be in a master branch this kind of solution.
| @@ -134,7 +137,14 @@ public void run() { | |||
| di.channelResolution = new DatasetInfo.ResolutionWithOwnUnit(channel_res, channel_unit); | |||
| di.angleResolution = new DatasetInfo.ResolutionWithOwnUnit(angle_res, angle_unit); | |||
|
|
|||
| di.compression = this.compression.equals("none") ? "raw" : this.compression; | |||
| //di.compression = this.compression.equals("none") ? "raw" : this.compression; | |||
There was a problem hiding this comment.
Remove commented part of code before integration.
| @Override | ||
| public void run() { | ||
| //logging facility | ||
| myLogger = mainLogger.subLogger("HPC CreateDataset", LogLevel.INFO); | ||
|
|
||
| try { | ||
| final HttpURLConnection connection = (HttpURLConnection)new URL("http://"+this.url+"/datasets").openConnection(); | ||
| String add="/datasets"; |
There was a problem hiding this comment.
why the local variable is introduced?
| @@ -105,7 +105,9 @@ protected void updateSpatialRanges() { | |||
| /** updates currentResLevel given the current choice in resolutionLevelsAsStr, | |||
| sets currentResLevel to null when resolutionLevelsAsStr is not valid */ | |||
| protected void matchResLevel() { | |||
| //TODO CLEAR | |||
| myLogger.info("going to match against: "+resolutionLevelsAsStr); | ||
| System.out.println(resolutionLevelsAsStr); |
There was a problem hiding this comment.
do not use println for logging.
| @@ -32,6 +32,7 @@ public class DatasetInfo { | |||
| public List<Integer> versions; | |||
| public String label; | |||
|
|
|||
|
|
|||
|
Cleaned up from old TODOS etc. |
kozusznik
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.