-
Notifications
You must be signed in to change notification settings - Fork 4
Fhir server integration and patient searching/opening #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Initial FHIR server integration. Uses a default hardcoded FHIR server and can search a patient and study on that server.
Added configurable FHIR server support and patient searching given an ID or name.
lbergnehr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get it to build and neither can Travis. Check if you can resolve that and I'll have another go at it. Perhaps it has something to do with that added reference I mentioned in another comment.
Common/Common.csproj
Outdated
|
|
||
| <ItemGroup> | ||
| <Reference Include="Microsoft.AspNetCore.Mvc.ViewFeatures"> | ||
| <HintPath>..\..\..\..\..\..\Program Files\dotnet\sdk\NuGetFallbackFolder\microsoft.aspnetcore.mvc.viewfeatures\2.1.1\lib\netstandard2.0\Microsoft.AspNetCore.Mvc.ViewFeatures.dll</HintPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will build as it's an absolute reference on your computer. Could you add that reference as a NuGet package instead? Like what you're doing on line 8 above.
|
Fixed that issue @lbergnehr, it passed the Travis build so should be good now. |
lbergnehr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review! I don't think we should have things stuck in review if they can be of use in the field. Let's fix things as they come up instead; but here are a few things that I came across:
- Using bootstrap from a cdn will effectively require you to have internet access when developing on this.
- Some
camelCasewhere it should bePascalCase. - Formatting (which we haven't set) with braces on the next line, whereas the history of the code so far has been mainly braces on the same line as the method (or whatever construct).
- The static model (
internalModel) will be a world of hurt for me, or us, when merging the signalr branch since that kind of challenges that model completely.
Great work with fetching the data from a FHIR server! Will sure come in handy when using this cross vendors with different data sets.
Uh oh!
There was an error while loading. Please reload this page.