Chunk structure rewrite #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/lib/world/Cargo.toml # src/lib/world/benches/cache.rs # src/lib/world/benches/world.rs
ReCore-sys
requested changes
Jan 8, 2026
Collaborator
ReCore-sys
left a comment
ReCore-sys
left a comment
There was a problem hiding this comment.
Solid work, just a few (mostly performance) changes needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the chunk data structure to be more efficient both memory-wise and time-wise. It also sticks somewhat close to Mojang's implementation so that data can be prevented from being cloned more than once when being sent to the client.
The chunk data structure itself is mostly implemented, some things still need to be tweaked however.
This PR is still a draft because these things still need to be implemented:
Optimize chunk sections before saving to diskThis should be a separate PR because it requires a partial rewrite of the disk system which isn't in the scope of this PR. I'd like a separate disk format for chunks to ensure version compatibility.