feat(wasm): add CreateWasmFuncWithReturn for value-returning JS callbacks#28
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
CreateWasmFuncWithReturn— Value-Returning JS Callback ConstructorGothic WASM code can now hand a value-returning Go closure to JavaScript without
dropping down to
ExecJS.CreateWasmFuncWithReturnwrapssyscall/js.FuncOf, registers theclosure as a named global, and returns a
JSValueholding the underlyingjs.Funcso it can be assigned directly to a JS object property.
This closes the last gap in the Go→JS callback family. Until now we had:
CreateWasmFunc/CreateWasmStringFunc/CreateWasmBoolFunc— fire-and-forgetcallbacks invoked from HTML attributes, all returning
void.Third-party JS libraries (uPlot, Chart.js, Leaflet, ECharts, …) routinely accept
option callbacks that must return a value synchronously — axis tick formatters,
tooltip renderers, point-style resolvers. Those could not be expressed with the
void-returning helpers, forcing an
ExecJSstring-eval workaround that lost typesafety and Go-side state.
CreateWasmFuncWithReturnmakes them first-class.The
js.Funcis retained for the lifetime of the page (added to the runtimekeepslice and never released), matching the persistence semantics of the existing
AddEventListener*andCreateWasm*helpers — so it is safe to install once duringClientSideStatesetup.Signature
The returned
anyis marshalled back to JS via the same conversion used byJSValue.Set/Call, so returning aJSValue, a string, a number, or a bool all workas expected.
Example
Bug fixes / improvements
None.