I18n tests #61
Merged
I18n tests #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopalmeiro
reviewed
Sep 8, 2025
| const { t } = useIsolatedI18n( | ||
| internationalization?.language, | ||
| internationalization?.customTranslations, | ||
| ); |
There was a problem hiding this comment.
Why not passing internationalization only and wrap all the logic? Any reasons?
There was a problem hiding this comment.
Changed! nice point
joaopalmeiro
reviewed
Sep 8, 2025
joaopalmeiro
reviewed
Sep 8, 2025
joaopalmeiro
reviewed
Sep 8, 2025
joaopalmeiro
reviewed
Sep 8, 2025
DiogoRDuarte
force-pushed
the
i18n-tests
branch
from
24f8b29 to
78f8d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR: