Revert "Add new file context rabbitmq_conf_t." #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
np with reverting; but what will be the next step? |
Member
|
It's important also to understand, why we're reverting it and avoid it in future. |
Member
|
Also please explain the reason for reverting in the commit message. Revert without any explanation is a very bad practice. |
Contributor
|
@Richard-Filo, please include the explanation to the commit message so that it is clear and understandable and make the first comment match the commit message. |
Reverts fedora-selinux#179 Reason is that I forgot to ask maintainer of rabbitmq if it is expected behavior that a program which rabbitmq server uses, can write to own configuration file. I create BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1803126. And now I'm waiting for answer. In the meantime I'm reverting this PR.
Richard-Filo
force-pushed
the
revert-179-rabbitmq
branch
from
a92e4a0 to
82eb936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #179
Reason is that I forgot to ask maintainer of rabbitmq if it is expected behavior that a program which rabbitmq server uses, can write to own configuration file.
I create BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1803126.
And now I'm waiting for answer. In the meantime I'm reverting this PR.