Skip to content

feat(typebox): Update to latest TypeBox #3565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dove
Choose a base branch
from
Draft

feat(typebox): Update to latest TypeBox #3565

wants to merge 1 commit into from

Conversation

daffl
Copy link
Member

@daffl daffl commented Feb 14, 2025

No description provided.

Copy link

Deploying feathers-dove with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8170d2f
Status: ✅  Deploy successful!
Preview URL: https://bbd4623e.feathers.pages.dev
Branch Preview URL: https://typebox-latest.feathers.pages.dev

View logs

@daedalus28
Copy link

daedalus28 commented Jul 30, 2025

Based on the typebox changelog, the fix here might just be to replace the use of Intersects with Composite

schema: TObject | TIntersect | TUnion<TObject[]> | TRecord,

Type.Intersect(

return Type.Intersect(

@daffl The logs from the failed build are expired - can you rerun them to see what the errors are?

Edit: I just pulled the repo locally and tried to run the tests for this package. Regardless of whether Composite or Intersects is used, a TS2589: Type instantiation is excessively deep and possibly infinite. error happens. I'd suggest just constructing TypeScript types directly and using the typebox workbench to generate a modern typebox implementation.

Hopefully this comment is helpful.

@daffl
Copy link
Member Author

daffl commented Aug 1, 2025

The TypeBox workbench is neat. But yes, constructing the actual query you want to allow with basic TypeBox instead of having it try to somehow infer it would be my recommendation going forward, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants