Skip to content

fix: adjust enrollments filter query #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Tiago-Salles wants to merge 1 commit into
base: nau/teak.master
Choose a base branch
from
Draft

fix: adjust enrollments filter query #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nau_openedx_extensions/partner_integration/facade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ def _apply_base_enrollments_scope(self, base_enrollments_scope, courses_base_que

if base_enrollments_scope:
enrollments_query = use_read_replica_if_available(
CourseEnrollment.objects.filter(**base_enrollments_scope)
enrollments_query.filter(**base_enrollments_scope)
)

logger.info("Assembled enrollments base query by security scope.")
Expand Down
7 changes: 7 additions & 0 deletions nau_openedx_extensions/partner_integration/tests/test_facade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,13 @@ def test_apply_base_enrollments_scope_with_scope(self):
courses_query = CourseOverview.objects.filter(org="ENROLL_ORG")
result = self.facade._apply_base_enrollments_scope({"is_active": True}, courses_query)
self.assertTrue(result.filter(id=enrollment.id).exists())

def test_apply_base_enrollments_scope_with_scope_and_filtering(self):
"""With base_enrollments_scope provided, uses it for filtering."""
CourseEnrollmentFactory.create(user=self.user, course_id=self.course.id, is_active=True)
courses_query = CourseOverview.objects.filter(org="ENROLL_ORG", is_active=False)
result = self.facade._apply_base_enrollments_scope({"is_active": True}, courses_query)
self.assertTrue(len(result) == 0)

@patch("nau_openedx_extensions.partner_integration.facade.use_read_replica_if_available")
def test_apply_base_enrollments_scope_exception(self, mock_replica):
Expand Down
Loading