Skip to content

Conversation

@Aid55
Copy link
Contributor

@Aid55 Aid55 commented Apr 15, 2025

Set and Get a list of filters to choose which drops are broadcasted.
Two new commands provide the functionality.

@fatfingers23
Copy link
Owner

Thank you for the PR!

I wonder if the command could be made a bit more generic to cover a few other issues? Like the toggle so it is like
/set_custom_broadcast_filter notificationtype "hello,world"

So when we add it to more things like collection logs quests, etc we wont have to make a new command each time? So would be a second parameter with the type like here

@Aid55
Copy link
Contributor Author

Aid55 commented Apr 16, 2025

Made those changes.
Should now work for the broadcast types ItemDrop, RaidDrop, PetDrop, CollectionLog, Quest, Diary and PersonalBest

@fatfingers23
Copy link
Owner

LGTM! Thank you!

@fatfingers23 fatfingers23 merged commit 0418d0c into fatfingers23:main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants