fix: block HTML injection in advanced search results#4729
Merged
goranmoomin merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for char-cli-web canceled.
|
Collaborator
Author
|
via codex security audit |
- Sanitize highlighted title and content HTML with DOMPurify before rendering - Allow only `<mark>` tags so search highlighting still works without exposing raw HTML - Render memoized sanitized strings instead of passing raw highlight payloads to `dangerouslySetInnerHTML`
0e186c2 to
3b35e51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<mark>tags so search highlighting still works without exposing raw HTMLdangerouslySetInnerHTML