Skip to content

Refactor mic-detection-macos#4721

Closed
yujonglee wants to merge 1 commit intomainfrom
refactor-mic-detect-macos
Closed

Refactor mic-detection-macos#4721
yujonglee wants to merge 1 commit intomainfrom
refactor-mic-detect-macos

Conversation

@yujonglee
Copy link
Contributor

No description provided.

Signed-off-by: Yujong Lee <yujonglee.dev@gmail.com>
@netlify
Copy link

netlify bot commented Mar 24, 2026

Deploy Preview for char-cli-web canceled.

Name Link
🔨 Latest commit d2f88d5
🔍 Latest deploy log https://app.netlify.com/projects/char-cli-web/deploys/69c2263d43d3190008015fe7

@netlify
Copy link

netlify bot commented Mar 24, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit d2f88d5
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69c2263ddbd7ed000866b946

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

Comment on lines +5 to +6
pub(super) const START_CONFIRMATION: Duration = Duration::from_millis(500);
pub(super) const STOP_GRACE: Duration = Duration::from_secs(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Significant behavioral change: stop events now delayed by 3 seconds

The old code used a 500ms debounce for both start and stop events (crates/detect/src/mic/macos.rs:41 in the deleted file). The new code introduces a 3-second STOP_GRACE at crates/detect/src/mic/macos/state.rs:6 before confirming a mic stop, plus a device state re-check. This means downstream consumers (e.g., UI indicators) will see a 3-second delay before being notified that the mic stopped. This is presumably intentional (to avoid false stop events during brief interruptions like device switching), but consumers relying on timely stop notifications should be aware of this latency increase.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@yujonglee yujonglee closed this Mar 24, 2026
@yujonglee yujonglee deleted the refactor-mic-detect-macos branch March 24, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant