Skip to content

Apply cargo clippy fixes and normalize dprint formatting#4681

Open
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin/1773965047-clippy-fixes
Open

Apply cargo clippy fixes and normalize dprint formatting#4681
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin/1773965047-clippy-fixes

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 20, 2026

Summary

Originally ran cargo clippy --fix followed by cargo fmt across the workspace. After merging origin/main to resolve conflicts, the files that contained clippy fixes (crates/analytics/src/posthog.rs, plugins/listener/src/actors/recorder.rs, migration files) were deleted or reorganized on main — so the remaining diff is formatting-only.

Changes in final diff

  1. crates/audio-device/src/windows.rs: Import reordering to match dprint conventions (alphabetical, windows::core placement, Com:: import order)
  2. crates/audio-device/src/macos.rs: Tuple field access spacing (device.0.0device.0 .0 per rustfmt rules), if/else block expansion
  3. plugins/fs2/src/error.rs: Import reordering (serde::{Serialize, ser::Serializer}serde::{ser::Serializer, Serialize})

Updates since last revision

  • Fixed dprint formatting issues flagged by CI in windows.rs, macos.rs, and error.rs.
  • Note: CI errors in apps/cli/ (tokio::process resolution failures) are pre-existing on main and unrelated to this PR.

Review & Testing Checklist for Human

  • Verify the diff is formatting-only: The cumulative diff should contain no semantic changes. If any clippy fixes survived the merge, verify their correctness (especially let-chain collapses in migration files).
  • Confirm dprint CI passes: The fmt check should now be green. If not, run dprint fmt locally to identify remaining discrepancies between cargo fmt and dprint formatting rules.
  • Consider closing if no meaningful changes remain: Since the original clippy fixes were all in files that were deleted on main, this PR may have no substantive value beyond minor import reordering. Evaluate whether it's worth merging.

Recommended test plan: Verify CI fmt check passes. No functional testing needed — changes are purely cosmetic.

Notes

  • Platform-specific crates (tcc, am2, notch, tauri-nspanel, libspa/tools) could not be checked on Linux due to missing macOS/system dependencies.
  • The apps/cli/ CI failures (missing tokio::process feature) exist on main and are not introduced by this PR.

Link to Devin session: https://app.devin.ai/sessions/0814c7dbcbcc47728b0c2272f8f9483d

Co-Authored-By: bot_apk <apk@cognition.ai>
@netlify
Copy link

netlify bot commented Mar 20, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 4c8a963
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69bc96eee8c1690008e787a1

@netlify
Copy link

netlify bot commented Mar 20, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 4c8a963
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69bc96ee7158dc0007e3a52f

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration bot and others added 2 commits March 20, 2026 00:22
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
@devin-ai-integration devin-ai-integration bot changed the title Apply cargo clippy fixes and format code Apply cargo clippy fixes and normalize dprint formatting Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants