Skip to content

Conversation

kpfleming
Copy link
Contributor

Note: docs/guides/fastly_object_storage.md is a copy of templates/guides/fastly_object_storage.md, and can be ignored during the review process.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@kpfleming kpfleming requested review from rcaril and simonwistow July 2, 2025 18:56
@kpfleming kpfleming marked this pull request as ready for review July 2, 2025 18:56
@kpfleming kpfleming requested a review from a team as a code owner July 2, 2025 18:56
@kpfleming kpfleming requested review from a team and hcolwill and removed request for a team July 2, 2025 19:08
Copy link
Contributor

@rcaril rcaril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me!

@gaylin gaylin requested review from gaylin and removed request for hcolwill July 3, 2025 14:02
Copy link
Contributor

@gaylin gaylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpfleming , I've put in a few suggestions, some of which aren't blockers, and tried to explain the logic for everything I've suggested. Happy to review this again at any time.

@kpfleming
Copy link
Contributor Author

Thanks for the review! All of the suggestions made sense to me and have been applied.

Copy link
Contributor

@gaylin gaylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@kpfleming kpfleming merged commit 97305f0 into fastly:main Jul 8, 2025
11 checks passed
@kpfleming kpfleming deleted the add-fos-guide branch July 8, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants