-
Notifications
You must be signed in to change notification settings - Fork 144
Add Fastly Object Storage guide to documentation. #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpfleming , I've put in a few suggestions, some of which aren't blockers, and tried to explain the logic for everything I've suggested. Happy to review this again at any time.
Co-authored-by: Gaylin Walli <[email protected]>
Thanks for the review! All of the suggestions made sense to me and have been applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note:
docs/guides/fastly_object_storage.md
is a copy oftemplates/guides/fastly_object_storage.md
, and can be ignored during the review process.All Submissions: