Skip to content

Conversation

philippschulte
Copy link
Member

@philippschulte philippschulte commented Jun 25, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
  • Post the output of your test runs

@philippschulte philippschulte requested a review from a team as a code owner June 25, 2025 12:59
@kpfleming kpfleming requested review from kpfleming and removed request for anthony-gomez-fastly June 27, 2025 17:32
@kpfleming kpfleming force-pushed the pschulte/CDTOOL-xxxx_add-workspace-resource branch 2 times, most recently from 001eeee to 0b49333 Compare June 27, 2025 18:00
@kpfleming kpfleming changed the title [CDTOOL-XXX] Add support for ngwaf workspaces [CDTOOL-1098] Add support for ngwaf workspaces Jun 27, 2025
philippschulte and others added 2 commits July 1, 2025 11:08
* Add the data source and resource schemas in fastly/provider.go

* Add templates for documentation, and examples.

* Use descriptions from public API documentation for all schema
  attributes.

* Ensure that schema attributes which have defaults and/or limited
  options are documented in their descriptions.

* Sort schema attributes.

* Add CHANGELOG entry.

* Change names of generated workspaces in data-source test to be
  unique.
@kpfleming kpfleming force-pushed the pschulte/CDTOOL-xxxx_add-workspace-resource branch from f804e2f to d34e7d9 Compare July 1, 2025 15:11
@philippschulte
Copy link
Member Author

@kpfleming thanks for completing the PR! Both test pass:

TF_ACC=1 go  test $(go  list ./...) -v -run=TestAccFastlyNGWAFWorkspace_validate -parallel=4 -timeout 360m -ldflags="-X=github.com/fastly/terraform-provider-fastly/version.ProviderVersion=acc"
?   	github.com/fastly/terraform-provider-fastly	[no test files]
=== RUN   TestAccFastlyNGWAFWorkspace_validate
=== PAUSE TestAccFastlyNGWAFWorkspace_validate
=== CONT  TestAccFastlyNGWAFWorkspace_validate
--- PASS: TestAccFastlyNGWAFWorkspace_validate (11.85s)
PASS
TF_ACC=1 go  test $(go  list ./...) -v -run=TestAccFastlyDataSourceNGWAFWorkspaces_Config -parallel=4 -timeout 360m -ldflags="-X=github.com/fastly/terraform-provider-fastly/version.ProviderVersion=acc"
?   	github.com/fastly/terraform-provider-fastly	[no test files]
=== RUN   TestAccFastlyDataSourceNGWAFWorkspaces_Config
=== PAUSE TestAccFastlyDataSourceNGWAFWorkspaces_Config
=== CONT  TestAccFastlyDataSourceNGWAFWorkspaces_Config
--- PASS: TestAccFastlyDataSourceNGWAFWorkspaces_Config (12.68s)
PASS

@philippschulte philippschulte requested a review from rcaril July 2, 2025 12:55
@philippschulte philippschulte merged commit 7548ad5 into fastly:main Jul 3, 2025
11 checks passed
@philippschulte philippschulte deleted the pschulte/CDTOOL-xxxx_add-workspace-resource branch July 3, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants