Skip to content

fix: Fix string formatting for limit-exceeded errors #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: Fix string formatting for limit-exceeded errors #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions runtime/fastly/host-api/host_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,9 @@ void handle_fastly_error(JSContext *cx, APIError err, int line, const char *func
break;
case FASTLY_COMPUTE_AT_EDGE_TYPES_ERROR_LIMIT_EXCEEDED:
JS_ReportErrorUTF8(cx,
"%s: Limit exceeded error. This error will be thrown when an attempt"
"to allocate a resource has exceeded the maximum number of resources"
"permitted. For example, creating too many response handles."
"\n",
"%s: Limit exceeded error. This error will be thrown when an attempt "
"to allocate a resource has exceeded the maximum number of resources "
"permitted. For example, creating too many response handles.\n",
func);
break;
default:
Expand Down
7 changes: 3 additions & 4 deletions runtime/js-compute-runtime/host_interface/host_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,9 @@ void handle_fastly_error(JSContext *cx, FastlyError err, int line, const char *f
break;
case FASTLY_COMPUTE_AT_EDGE_TYPES_ERROR_LIMIT_EXCEEDED:
JS_ReportErrorUTF8(cx,
"%s: Limit exceeded error. This error will be thrown when an attempt"
"to allocate a resource has exceeded the maximum number of resources"
"permitted. For example, creating too many response handles."
"\n",
"%s: Limit exceeded error. This error will be thrown when an attempt "
"to allocate a resource has exceeded the maximum number of resources "
"permitted. For example, creating too many response handles.\n",
func);
break;
default:
Expand Down