test: raise memory thresholds in memoryUsage namespace test - #299
Merged
Merged
Conversation
Member
|
Sounds good, let's wait for Matteo review imo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
The
memoryUsage name spacetest registers the plugin withmaxRssBytes: 100000000(100 MB) and apressureHandlerthat asserts it is never called. That threshold is too close to the actual footprint of a modern Node.js process: on Linux with Node 22 the RSS at that point of the test file is already ~95 MB, and on macOS with Node 26 (added to the matrix by fastify/workflows v7.0.0) with coverage enabled it exceeds 100 MB.When that happens the plugin invokes the
pressureHandler,t.assert.ok(false)throws inside the hook, Fastify turns it into a 500 and the test fails with an opaque message:This is what blocks #296.
The test only verifies that the
fastify.memoryUsage()namespace works and that no pressure is detected; it does not exercise the thresholds. This PR:maxHeapUsedBytes/maxRssBytesto 1e9 andmaxEventLoopUtilizationto 0.99 so they cannot be hit by the runtime footprintt.assert.ok(false)reporting which metric triggered the handler and with which valueNote:
index.js, behaviour under test is unchanged.