docs: deprecate fastrace-jaeger and fastrace-datadog#187
Merged
Conversation
Closes: fast#186 Signed-off-by: Jiawei Zhao <Phoenix500526@163.com>
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR deprecates the fastrace-jaeger and fastrace-datadog crates in favor of fastrace-opentelemetry, aligning the project’s guidance with OTLP-native ingestion paths (Jaeger v1.35+ and Datadog Agent OTLP ingest).
Changes:
- Added prominent deprecation notices to both crate READMEs, pointing users to
fastrace-opentelemetry. - Added migration guidance (including an OTLP-based reporter example) for Datadog, and a brief migration note for Jaeger.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fastrace-jaeger/README.md | Adds a deprecation warning and brief migration pointer to fastrace-opentelemetry. |
| fastrace-datadog/README.md | Adds a deprecation warning plus a more detailed OTLP migration section and example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
approved these changes
Jun 16, 2026
tisonkun
left a comment
tisonkun
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Pushed two follow-up commits.
You may test if the example code can compile the next time.
Signed-off-by: tison <wander4096@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #186