Fix overlay positioning on secondary monitors#72
Open
GithubAnant wants to merge 2 commits intofarzaa:mainfrom
Open
Fix overlay positioning on secondary monitors#72GithubAnant wants to merge 2 commits intofarzaa:mainfrom
GithubAnant wants to merge 2 commits intofarzaa:mainfrom
Conversation
…n secondary displays
…n secondary displays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a multi-monitor positioning issue where the buddy overlay could render outside the visible bounds on non-primary displays.
What was happening
The hosting view inside each overlay window was being positioned using global screen coordinates. On secondary monitors, that could place content outside the window’s local coordinate space, making the buddy appear only on the first screen.
What changed
Updated the overlay hosting view to:
use a local origin of (0, 0)
size to the current screen’s dimensions
resize with the window via autoresizing mask
It's just one file with changes so should be super easy!