persist Seq2Seq through keras load - save api#224
Open
stefanoterna wants to merge 5 commits intofarizrahman4u:masterfrom
Open
persist Seq2Seq through keras load - save api#224stefanoterna wants to merge 5 commits intofarizrahman4u:masterfrom
stefanoterna wants to merge 5 commits intofarizrahman4u:masterfrom
Conversation
…ided as arg. in turn output_dim is not available as self until super construcor has been called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
get_configoverride method to handlehidden_diminLSTMDecoderCellandAttentionDecoderCell.Moreover, the constructors of both classes relied on
self.output_dimto set the value ofhidden_dimif not supplied. Butself.output_dimis not available until super constructor has been called. Fixed by accessing directly to kwargs, so thathidden_dimis be available when the super constructor calls thebuild_modelmethod.