Open
Conversation
riesentoaster
requested changes
Jan 21, 2026
Collaborator
riesentoaster
left a comment
There was a problem hiding this comment.
We should probably also add this to the docs somewhere. @andreas-zeller what do you think? Suggestions?
| max_nodes: int = 200, | ||
| max_nodes_rate: float = 0.5, | ||
| profiling: bool = False, | ||
| stop_criterion: str = "lambda t: False", |
Collaborator
There was a problem hiding this comment.
The arg here shouldn't be a string to be evaled, it should be the optional parsed function. And the same applies to the outside interface. And if the arg isn't passed in the command line, this should be an empty optional and not a constant function, just like in downstream calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are useful for setting up Fandango experiments, as explained in the comments.