Skip to content

fix: narval connector sdk can be used #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattschoch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: narval connector sdk can be used #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/connectkit/src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ export const isMetaMaskConnector = (connectorId?: string) =>
export const isCoinbaseWalletConnector = (connectorId?: string) =>
connectorId === 'coinbaseWalletSDK';

export const isNarvalConnector = (connectorId?: string) =>
!!connectorId?.startsWith('narval-');

export const isLedgerConnector = (connectorId?: string) =>
connectorId === 'ledger';

Expand Down
9 changes: 7 additions & 2 deletions packages/connectkit/src/wallets/useWallets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ import { Connector } from 'wagmi';
import { useConnectors } from '../hooks/useConnectors';
import { walletConfigs, WalletConfigProps } from './walletConfigs';
import { useContext } from '../components/ConnectKit';
import { isCoinbaseWalletConnector, isInjectedConnector } from '../utils';
import {
isCoinbaseWalletConnector,
isInjectedConnector,
isNarvalConnector,
} from '../utils';

export type WalletProps = {
id: string;
Expand Down Expand Up @@ -48,7 +52,8 @@ export const useWallets = (): WalletProps[] => {
isInstalled:
connector.type === 'mock' ||
(connector.type === 'injected' && connector.id !== 'metaMask') ||
isCoinbaseWalletConnector(connector.id), // always run coinbase wallet SDK
isCoinbaseWalletConnector(connector.id) || // always run coinbase wallet SDK
isNarvalConnector(connector.id), // always run narval connect sdk if provided
};

if (walletId) {
Expand Down