feat: add support for base account#467
Open
pradel wants to merge 4 commits into
Open
Conversation
|
@pradel is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
pradel
force-pushed
the
feat/add-base-account
branch
from
d9980a4 to
e646840
Compare
Author
|
@lochie any feedback on the pr? Thanks 🙏 |
|
@pradel can you please merge master and resolve conflicts in this PR - we'll try to get this reviewed once you do that. Thanks ! |
Author
|
@youssefea conflicts resolved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add base account support to connectkit.
This pr was created following the migration guide recommendations: https://docs.base.org/base-account/guides/migration-guide.
The Base Account SDK is the successor to the Coinbase Wallet SDK, which is now considered legacy. To allow users with the Coinbase wallet extension to connect, I left the Coinbase connector for now, but once a migration path is available, it can be removed.
^2.16.0(version where the base connector was added)^2.31.7(required by@base-org/accountpeer deps)Let me know your thoughts on the pr, thanks!