chore(k8smeta): simplify cmake scripts and use Vcpkg for dependencies #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: irozzo-1A The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
irozzo-1A
changed the title
Rules files suggestions |
irozzo-1A
force-pushed
the
use-vcpkg-for-k8smeta
branch
from
9b7bfe1 to
f8268f0
Compare
Rules files suggestions |
irozzo-1A
force-pushed
the
use-vcpkg-for-k8smeta
branch
from
f8268f0 to
c0da017
Compare
89 tasks
irozzo-1A
force-pushed
the
use-vcpkg-for-k8smeta
branch
from
8e6c9e4 to
9b73fc0
Compare
Rules files suggestions |
irozzo-1A
force-pushed
the
use-vcpkg-for-k8smeta
branch
from
9b73fc0 to
b8cf808
Compare
irozzo-1A
force-pushed
the
use-vcpkg-for-k8smeta
branch
3 times, most recently
from
7c84c87 to
cd5490e
Compare
Rules files suggestions |
Rules files suggestions |
1 similar comment
Rules files suggestions |
Simplify the cmake scripts by using `find_package` and VCPKG. Also generate the gRPC files using `protobuf_generate` instead of using a custom command. Signed-off-by: Iacopo Rozzo <[email protected]>
irozzo-1A
force-pushed
the
use-vcpkg-for-k8smeta
branch
from
a22c71e to
451f94b
Compare
Rules files suggestions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
Running the k8smeta plugin with Falco 0.42.0-rc1 is causing the following crash:
This PR simplifies the cmake scripts by using
find_packageand VCPKG, this guarantees that all the dependencies are correctly linked in the shared lib.It also generate the gRPC files using
protobuf_generateinstead of using a custom command.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: