Skip to content

Conversation

@jfcoz
Copy link

@jfcoz jfcoz commented Nov 26, 2025

What type of PR is this?

/kind cleanup
/area build

What this PR does / why we need it:

falcoctl is added in a layer, then deleted (hidden) in another layer.

The rm falcoctl is now in the same image layer, this divides the image size by 2.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Nov 26, 2025

Welcome @jfcoz! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Nov 26, 2025
@leogr
Copy link
Member

leogr commented Nov 26, 2025

/milestone 0.43.0

Good catch! I will keep this PR on hold for a bit because we are having some CI issues.

That said, your contribution is really appreciated, and I wanted to let you know.
Thanks!

@poiana poiana added this to the 0.43.0 milestone Nov 26, 2025
@jfcoz jfcoz mentioned this pull request Nov 26, 2025
@poiana poiana added the lgtm label Dec 1, 2025
@poiana
Copy link
Contributor

poiana commented Dec 1, 2025

LGTM label has been added.

Git tree hash: b1939efb5ba5cb4a50ada35f51a36f82b7cf596c

@leogr
Copy link
Member

leogr commented Dec 1, 2025

Hey @jfcoz

May I ask you to rebase this on the current master, please? It should solve an issue we are facing with the CI 👇
image

Thanks 🙏

rm falcoctl in the same image layer, divides the image size by 2.

Signed-off-by: Julien Francoz <[email protected]>
@jfcoz jfcoz force-pushed the reduce_image_size branch from 4a0d1b3 to 21bd9ef Compare December 1, 2025 13:54
@poiana poiana removed the lgtm label Dec 1, 2025
@poiana poiana requested a review from leogr December 1, 2025 13:54
@poiana
Copy link
Contributor

poiana commented Dec 1, 2025

New changes are detected. LGTM label has been removed.

@poiana
Copy link
Contributor

poiana commented Dec 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jfcoz
Once this PR has been reviewed and has the lgtm label, please ask for approval from leogr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jfcoz
Copy link
Author

jfcoz commented Dec 3, 2025

@leogr , rebase was done

@leogr
Copy link
Member

leogr commented Dec 3, 2025

@leogr , rebase was done

Thank you.

Unfortunately, we are still facing issue with ghcr.io rate limiting us. However, this is on our side, we are trying to fix it. No action items to you.

And thank you again for your contribution! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants