-
Notifications
You must be signed in to change notification settings - Fork 964
Reduce image size #3746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reduce image size #3746
Conversation
|
Welcome @jfcoz! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
/milestone 0.43.0 Good catch! I will keep this PR on hold for a bit because we are having some CI issues. That said, your contribution is really appreciated, and I wanted to let you know. |
|
LGTM label has been added. Git tree hash: b1939efb5ba5cb4a50ada35f51a36f82b7cf596c
|
|
Hey @jfcoz May I ask you to rebase this on the current Thanks 🙏 |
rm falcoctl in the same image layer, divides the image size by 2. Signed-off-by: Julien Francoz <[email protected]>
4a0d1b3 to
21bd9ef
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jfcoz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@leogr , rebase was done |
Thank you. Unfortunately, we are still facing issue with ghcr.io rate limiting us. However, this is on our side, we are trying to fix it. No action items to you. And thank you again for your contribution! 🙏 |

What type of PR is this?
/kind cleanup
/area build
What this PR does / why we need it:
falcoctlis added in a layer, then deleted (hidden) in another layer.The
rm falcoctlis now in the same image layer, this divides the image size by 2.Special notes for your reviewer:
Does this PR introduce a user-facing change?: