Skip to content

Conversation

ZigaVukcevicDev
Copy link

No description provided.

Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bedddc5
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/686d5dbee20f570008e0ef16
😎 Deploy Preview https://deploy-preview-3564.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ZigaVukcevicDev ZigaVukcevicDev changed the title Locale sl_SI feat(locale):sl_SI Jul 7, 2025
@ZigaVukcevicDev ZigaVukcevicDev changed the title feat(locale):sl_SI feat(locales):sl_SI Jul 7, 2025
@ZigaVukcevicDev ZigaVukcevicDev changed the title feat(locales):sl_SI feat(locales): add sl_SI locale Jul 7, 2025
@matthewmayer
Copy link
Contributor

Thanks!

Note for the initial PR for adding a language we recommend adding one module only (e.g. person as you have done here). Please don't add additional modules to this PR until it has been reviewed and approved. Once it's approved you can follow up with additional PRs to add further modules.

Note also we are soon releasing v10, a major release, so we likely won't merge this imminently. It is more likely to make it into a v10.1 release in a few weeks.

@matthewmayer matthewmayer marked this pull request as ready for review July 7, 2025 21:03
@matthewmayer matthewmayer requested a review from a team as a code owner July 7, 2025 21:03
@matthewmayer
Copy link
Contributor

You are currently missing the first_name and last_name files.

@ZigaVukcevicDev ZigaVukcevicDev changed the title feat(locales): add sl_SI locale feat(locales): add sl_SI locale for person Jul 8, 2025
@ZigaVukcevicDev
Copy link
Author

@matthewmayer I know they were missing, this is why PR was set to draft. Thank you for the notice though.

I have added them now.

@ZigaVukcevicDev
Copy link
Author

I tried to run pnpm run preflight but ran into errors

Screenshot 2025-07-08 at 18 03 14

I am asking for some assistance on how to approach this issue, thank you.

@Shinigami92
Copy link
Member

I tried to run pnpm run preflight but ran into errors

Screenshot 2025-07-08 at 18 03 14

I am asking for some assistance on how to approach this issue, thank you.

I'll run the CI and so we can identify if it's a real error or just a local one to your environment

@Shinigami92
Copy link
Member

I assume it has todo something with that suffix is null in this PR
Can't check right now immediately cause I'm on mobile

@ZigaVukcevicDev
Copy link
Author

@Shinigami92 I have updated file src/locales/sl_SI/person/suffix.ts with array of values instead of null and problem is solved.

@ZigaVukcevicDev
Copy link
Author

Ready for review. Thank you.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (93416f7) to head (bedddc5).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3564    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2888     2908    +20     
  Lines      221958   222794   +836     
  Branches      930      928     -2     
========================================
+ Hits       221889   222725   +836     
  Misses         69       69            
Files with missing lines Coverage Δ
src/locale/index.ts 100.00% <100.00%> (ø)
src/locale/sl_SI.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/index.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/metadata.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/person/bio_part.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/person/bio_pattern.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/person/bio_supporter.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/sl_SI/person/index.ts 100.00% <100.00%> (ø)
... and 12 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewmayer
Copy link
Contributor

For future reference, If you don't want to provide suffixes for a locale, thats fine (not all languages have them) but then you need to add the locale to line 61 of test/all-functional.spec.ts to allow the test to pass

@ZigaVukcevicDev ZigaVukcevicDev changed the title feat(locales): add sl_SI locale for person feat(locales): add sl_SI locale, person module Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants