-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(locales): add sl_SI locale, person module #3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thanks! Note for the initial PR for adding a language we recommend adding one module only (e.g. person as you have done here). Please don't add additional modules to this PR until it has been reviewed and approved. Once it's approved you can follow up with additional PRs to add further modules. Note also we are soon releasing v10, a major release, so we likely won't merge this imminently. It is more likely to make it into a v10.1 release in a few weeks. |
You are currently missing the first_name and last_name files. |
@matthewmayer I know they were missing, this is why PR was set to draft. Thank you for the notice though. I have added them now. |
I assume it has todo something with that suffix is null in this PR |
@Shinigami92 I have updated file |
Ready for review. Thank you. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3564 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 2888 2908 +20
Lines 221958 222794 +836
Branches 930 928 -2
========================================
+ Hits 221889 222725 +836
Misses 69 69
🚀 New features to boost your workflow:
|
For future reference, If you don't want to provide suffixes for a locale, thats fine (not all languages have them) but then you need to add the locale to line 61 of |
No description provided.