Skip to content

Conversation

@JohnCoene
Copy link

Thank you for the great package, I'm relying on it quite a bit now, I'm just encountering two issues:

  1. See SetMaxOpenConns > zookeepers #5, we check for d.nextBit >= len(newClient.drillBits) but eindex can remain out of range.

eindex := d.nextBit

  1. The other issue, I'm not sure why sometimes the path is wrong and set to mydrillbit instead of /drill/mydrillbit.

data, _, err := z.conn.Get(z.Path + "/" + drillbit)

This causes the connection to error ("invalid path") but it seems z.Err is never really checked. I'm not sure where this should be checked though.

z.Err = err

This PR fixes these, though maybe not elegantly.

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants