Properly expose writer functionality in pyvrs/oss #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add a number of OSS issues that accumulated over time: - extractAudio was added, but can't be used in oss from its location (linkage issues). Disabling in pyvrs/oss for now. - back-ported cmake install workaround from the vrs/oss repo Differential Revision: D87478397
Summary: The writer code was not properly built & registered in oss. Differential Revision: D87686636 Privacy Context Container: L1396930
|
@georges-berenger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87686636. |
|
This pull request has been merged in c965cb7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The writer code was not properly built & registered in oss.
Differential Revision:
D87686636
Privacy Context Container: L1396930