Ensure the process id to thread id to node id index is maintained. #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanrise
requested review from
briancoutinho,
kingchc,
louisfeng,
shengbao-zheng and
sunghlin
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71565563 |
sanrise
commented
Mar 20, 2025
et_replay/execution_trace.py
Outdated
| tid = self.nodes[id].tid | ||
| self.proc_group[pid][tid] = id | ||
| tid = self.nodes[id].tid | ||
| self.proc_group[pid][tid] = id |
Contributor
Author
There was a problem hiding this comment.
will make this a list
sanrise
added a commit
to sanrise/param
that referenced
this pull request
Mar 20, 2025
…acebookresearch#200) Summary: Currently this map is not set since __ROOT_THREAD__ is not a valid node anymore. We can safely read thr pid and tid against a node id and store in this map. Differential Revision: D71565563
sanrise
force-pushed
the
export-D71565563
branch
from
916cd95 to
199fbe4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71565563 |
Contributor
|
Hi Darshan, the second dictionary of self.proc_group is a map between thread id to the thread node id. After your change, it becomes the thread id to the list of nodes belong to that thread. I think the fix is to change ROOT_THREAD to [pytorch|profiler|execution_trace|thread] |
sanrise
added a commit
to sanrise/param
that referenced
this pull request
Mar 21, 2025
…acebookresearch#200) Summary: Currently this map is not set since __ROOT_THREAD__ is not a valid node anymore. We can safely read thr pid and tid against a node id and store in this map. Differential Revision: D71565563
sanrise
force-pushed
the
export-D71565563
branch
from
199fbe4 to
15aade9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71565563 |
shengfukevin
approved these changes
Mar 21, 2025
Contributor
shengfukevin
left a comment
shengfukevin
left a comment
There was a problem hiding this comment.
LG2M! Thanks for the fix.
…acebookresearch#200) Summary: Currently this map is not set since __ROOT_THREAD__ is not a valid node anymore. We can safely read thr pid and tid against a node id and store in this map. Reviewed By: shengfukevin Differential Revision: D71565563
sanrise
force-pushed
the
export-D71565563
branch
from
15aade9 to
251307d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71565563 |
Contributor
|
This pull request has been merged in 75d1473. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently this map is not set since ROOT_THREAD is not a valid node anymore. We can safely read thr pid and tid against a node id and store in this map.
Differential Revision: D71565563