Conversation
meta-cla
Bot
added
the
CLA Signed
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 353e602c9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Dataclass and attrs instances are passed through without | ||
| conversion or recursive instantiation. |
There was a problem hiding this comment.
When a dataclass or attrs instance subclasses dict or list, _prepare_input_value() still recognizes it via isinstance() and recursively converts it into a plain container before override processing, so the target does not receive the original object as promised here. This affects valid structured runtime objects such as @dataclass class RuntimeDict(dict); exclude structured instances from native-container normalization or restrict that normalization to exact built-in container types.
Useful? React with 👍 / 👎.
Pass already-constructed dataclass and attrs instances to instantiate targets unchanged instead of implicitly converting them to Structured Configs. Keep native and explicit OmegaConf containers on the configuration path. Add regression coverage for identity passthrough, special constructors, attrs, and explicit structured overrides. Document the Hydra 1.4 breaking change and migration, and add attrs to the test environments. Closes #2364
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pass already-constructed dataclass and attrs instances to instantiate targets unchanged instead of implicitly converting them to Structured Configs.
Keep native and explicit OmegaConf containers on the configuration path. Add regression coverage for identity passthrough, special constructors, attrs, and explicit structured overrides.
Document the Hydra 1.4 breaking change and migration, and add attrs to the test environments.
Closes #2364