Conversation
Cover the lazy-registration behavior fixed by pull request 2928. Build a CachingConfigRepository before registering a structured config, then verify the copied repository discovers and loads the new config through the live ConfigStore. Follow-up to #2928
meta-cla
Bot
added
the
CLA Signed
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test to ensure CachingConfigRepository continues to resolve structured configs via the current ConfigStore singleton even after the repository is deep-copied (covering the lazy-registration scenario addressed in #2928).
Changes:
- Add a new test that constructs a
CachingConfigRepository, then registers a structured config afterward, and asserts the repository can discover and load it. - Update imports in
tests/test_config_repository.pyto includeCachingConfigRepositoryandConfigStore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover the lazy-registration behavior fixed by pull request 2928. Build a CachingConfigRepository before registering a structured config, then verify the copied repository discovers and loads the new config through the live ConfigStore.
Follow-up to #2928