clean up serialization tests #4700
Closed
+50
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary: A pass over the serialization / deserialization tests, so that they don't use temp files when not needed. Reviewed By: pankajsingh88, junjieqi Differential Revision: D87615610
mdouze
force-pushed
the
export-D87615610
branch
from
ad4f430 to
4f66948
Compare
Contributor
|
This pull request has been merged in 1ea99d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A pass over the serialization / deserialization tests, so that they don't use temp files when not needed.
Reviewed By: junjieqi
Differential Revision: D87615610