Skip to content

Conversation

@rsyue
Copy link
Contributor

@rsyue rsyue commented Nov 20, 2025

What does this PR do? Please describe:
Resolved tensor casting issues introduced with PyTorch 2.10 changes, as indicated in #D87484341

This brings the update to OSS.

Does your PR introduce any breaking changes? If yes, please list them:
None known

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
Copy link
Contributor

@cbalioglu cbalioglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Have you verified that the code compiles successfully with PyTorch nightlies?

@rsyue
Copy link
Contributor Author

rsyue commented Nov 21, 2025

Thanks for the PR! Have you verified that the code compiles successfully with PyTorch nightlies?

Everything builds fine with the nightly 2.10 build

Copy link
Contributor

@cbalioglu cbalioglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbalioglu cbalioglu merged commit 7f67ba8 into main Nov 21, 2025
15 checks passed
@cbalioglu cbalioglu deleted the richard/pt_2_10_tensor_bugfix branch November 21, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants