Skip to content

+1 to seq len for entropy model #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sriniiyer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

+1 to seq len for entropy model #95

sriniiyer wants to merge 1 commit into from

Conversation

@sriniiyer
Copy link
Contributor

@sriniiyer sriniiyer commented Apr 9, 2025

Adding +1 to seq len of entropy model to closer match model trained for the paper

Also fixing some masks

@sriniiyer sriniiyer requested a review from EntilZha April 9, 2025 00:20
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 9, 2025
EntilZha
EntilZha approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@EntilZha EntilZha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EntilZha EntilZha EntilZha approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sriniiyer @EntilZha @facebook-github-bot