Make DISPLAY_LEVEL_DEFAULT configurable at compile time#4620
Open
jlee303 wants to merge 1 commit intofacebook:devfrom
Open
Make DISPLAY_LEVEL_DEFAULT configurable at compile time#4620jlee303 wants to merge 1 commit intofacebook:devfrom
jlee303 wants to merge 1 commit intofacebook:devfrom
Conversation
Cyan4973
reviewed
Mar 10, 2026
|
|
||
| #define DISPLAY_LEVEL_DEFAULT 3 | ||
| #ifndef ZSTD_DISPLAY_LEVEL_DEFAULT | ||
| #define ZSTD_DISPLAY_LEVEL_DEFAULT 3 |
Contributor
There was a problem hiding this comment.
minor: indent:
in the zstd code base, within an #ifdef section, we typically write
# define ZSTD_DISPLAY_LEVEL_DEFAULT N
notice the space between # and define.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables DISPLAY_LEVEL_DEFAULT to be configured at compile time by wrapping it in #ifndef guards and adding the ZSTD_ prefix to avoid namespace pollution. Allows for quieter output without need to pass in -q every invocation.
To verify change, compare difference in verbosity with
makevsCPPFLAGS='-DZSTD_DISPLAY_LEVEL_DEFAULT=3' makeThanks @tansy for suggestion! #4492