Support external builds of xgboost/arrow#794
Conversation
|
Hi @chrisburr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I wonder if we could have a CI test for this scenario, thus proving it works, but also ensuring it continues to work in the future |
If the test is added the question is how to install the dependencies. I'm biased but my suggestion would be to add a It would also be possible to use conda-forge without using pixi but it then makes it more difficult to have a lock file for stability. |
Summary
Adds support for building against an external xgboost/arrow build. This is useful for package ecosystems with policies around vendoring and also fixes issues I had with the
ExternalProject_Addbuilds failing.Type of Change
Build/CI changes
Test Plan
Build locally in a pixi environment which had xgboost/arrow available externally.