Skip to content

Support external builds of xgboost/arrow#794

Open
chrisburr wants to merge 2 commits into
facebook:devfrom
chrisburr:external-project-fallback
Open

Support external builds of xgboost/arrow#794
chrisburr wants to merge 2 commits into
facebook:devfrom
chrisburr:external-project-fallback

Conversation

@chrisburr

Copy link
Copy Markdown

Summary

Adds support for building against an external xgboost/arrow build. This is useful for package ecosystems with policies around vendoring and also fixes issues I had with the ExternalProject_Add builds failing.

Type of Change

Build/CI changes

Test Plan

Build locally in a pixi environment which had xgboost/arrow available externally.

@meta-cla

meta-cla Bot commented May 29, 2026

Copy link
Copy Markdown

Hi @chrisburr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@chrisburr chrisburr changed the title Support external builds of external xgboost/arrow build Support external builds of xgboost/arrow May 29, 2026
@meta-cla

meta-cla Bot commented May 29, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@chrisburr chrisburr marked this pull request as ready for review May 29, 2026 14:47
@meta-cla meta-cla Bot added the cla signed label May 29, 2026
@Cyan4973 Cyan4973 added the build Build system and scripts label Jun 2, 2026
@Cyan4973

Cyan4973 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

I wonder if we could have a CI test for this scenario, thus proving it works, but also ensuring it continues to work in the future

@chrisburr

Copy link
Copy Markdown
Author

I wonder if we could have a CI test for this scenario, thus proving it works, but also ensuring it continues to work in the future

If the test is added the question is how to install the dependencies. I'm biased but my suggestion would be to add a pixi.toml to the repo and use conda-forge as the source of packages. I've already done this for my local environment so I'm happy to contribute it along with some GitHub Actions config.

It would also be possible to use conda-forge without using pixi but it then makes it more difficult to have a lock file for stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system and scripts cla signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants