Simplify ZL_OC_getLastError() (#706)#706
Open
felixhandte wants to merge 2 commits into
Open
Conversation
|
@felixhandte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101645608. |
meta-codesync
Bot
changed the title
ZL_OC_getLastError()ZL_OC_getLastError() (#706)
felixhandte
added a commit
to felixhandte/openzl
that referenced
this pull request
Jun 3, 2026
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Reviewed By: terrelln Differential Revision: D101645608
felixhandte
force-pushed
the
export-D101645608
branch
from
b064bf3 to
977f548
Compare
felixhandte
added a commit
to felixhandte/openzl
that referenced
this pull request
Jun 3, 2026
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Reviewed By: terrelln Differential Revision: D101645608
felixhandte
added a commit
to felixhandte/openzl
that referenced
this pull request
Jun 9, 2026
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Reviewed By: terrelln Differential Revision: D101645608
felixhandte
force-pushed
the
export-D101645608
branch
from
977f548 to
77b77ce
Compare
felixhandte
added a commit
to felixhandte/openzl
that referenced
this pull request
Jun 9, 2026
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Reviewed By: terrelln Differential Revision: D101645608
Summary: As title. Reviewed By: kevinjzhang Differential Revision: D101645553
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Differential Revision: D101645608
felixhandte
force-pushed
the
export-D101645608
branch
from
77b77ce to
f744620
Compare
felixhandte
pushed a commit
to felixhandte/openzl
that referenced
this pull request
Jun 15, 2026
Summary: This function maybe shouldn't exist. But we do use it in tests. At least simplify it by getting rid of this weird arg. Differential Revision: D101645608
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This function maybe shouldn't exist. But we do use it in tests. At least
simplify it by getting rid of this weird arg.
Differential Revision: D101645608