Add more distro_name() & distro_family() functionality #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use lsb_release if available on the remote system * Add support for Amazon Linux detection * Scan through /etc/redhat-release to check for centos/fedora * Detect Debian/Ubuntu family based on /etc/debian_version, as a fallback * Add mocked-up unit tests for some of the distro detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I've been using this module on a project of mine, and I've fleshed out a few more cases in distro_name() and distro_family(). I've also added a fallback in distro_family, for when you know you're on either debian or ubuntu, but can't tell which. Some test cases using mock are attached too.