refactor: replace Math.log with bit operations for node bits calculation #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the node-bits calculation in TsidFactory.Builder.getNodeBits() by replacing a floating-point logarithm expression with an equivalent integer bit operation.
This change improves clarity and mathematical robustness, and avoids unnecessary floating-point operations in a code path that runs only during factory initialization.
Why a Refactor?
Although the bit-operation approach is theoretically faster, this logic runs only once during startup, so the main motivation is not performance.
Instead, the change aims to:
Testing
The existing testWithNodeCount() test already covers all valid nodeBits cases (0–20), and the new implementation produces identical results, ensuring full backward compatibility.
Thank you for maintaining this excellent library!
Happy to revise anything if needed.