Skip to content

fix: remove unnecessary RETURNING * from database adapter update#555

Open
wschurman wants to merge 1 commit intomainfrom
wschurman/04-01-fix_remove_unnecessary_returning_from_database_adapter_update
Open

fix: remove unnecessary RETURNING * from database adapter update#555
wschurman wants to merge 1 commit intomainfrom
wschurman/04-01-fix_remove_unnecessary_returning_from_database_adapter_update

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented Apr 1, 2026

Why

When reviewing #540, I noticed that the RETURNING * isn't necessary, even in the normal case (since #233).

How

Remove the RETURNING *, return a simple updatedRowCount instead for error behavior.

Test Plan

Run tests.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wschurman wschurman marked this pull request as ready for review April 1, 2026 16:02
@wschurman wschurman requested a review from ide April 1, 2026 16:02
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4709f53) to head (50f5f25).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        17588     17583    -5     
  Branches      1515      1515           
=========================================
- Hits         17588     17583    -5     
Flag Coverage Δ
integration 28.35% <33.33%> (+0.01%) ⬆️
unittest 95.19% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* @param idField - the field in the object that is the ID
* @param id - the value of the ID field in the object
* @param object - the object to update
* @returns the updated object
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This docblock needs to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants