[eas-cli] Fix workflow detection for tracked gitignored files#3561
Open
[eas-cli] Fix workflow detection for tracked gitignored files#3561
Conversation
|
Subscribed to pull request
Generated by CodeMention |
59b7829 to
5ce625e
Compare
|
✅ Thank you for adding the changelog entry! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3561 +/- ##
==========================================
+ Coverage 54.38% 54.38% +0.01%
==========================================
Files 824 824
Lines 35420 35421 +1
Branches 7318 7319 +1
==========================================
+ Hits 19258 19259 +1
Misses 16075 16075
Partials 87 87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
resolveWorkflowAsync()decides between managed and generic by checking whether native workflow markers exist and whethervcsClient.isFileIgnoredAsync()says they are ignored.After the recent Git client rework,
GitClient.isFileIgnoredAsync()treated tracked files as never ignored when there was no.easignore. That matches a checked-out clone whenrequireCommit: true, but it does not match therequireCommit: falsearchive path, where we create a repo with--no-checkoutand then copy the working tree with.gitignorefiltering.That mismatch can make workflow detection report
GENERICeven though the uploaded archive no longer contains the native project.How
git check-ignore --no-indexwhenrequireCommitisfalse, so tracked files that would be filtered out of the working tree copy are treated as ignoredrequireCommitistrue, because those builds rely on a Git checkout.gitignorematchesresolveWorkflowAsync()directlyTest Plan
GitClient.isFileIgnoredAsync()behavior with tracked.gitignorematchesresolveWorkflowAsync()regression test for therequireCommit: falsevsrequireCommit: truesplityarnis not installed