Skip to content

[build-tools] Remove reuse_devices: false dead code#3560

Merged
sjchmiela merged 1 commit intomainfrom
stanley/remove-maestro-test-code
Apr 2, 2026
Merged

[build-tools] Remove reuse_devices: false dead code#3560
sjchmiela merged 1 commit intomainfrom
stanley/remove-maestro-test-code

Conversation

@sjchmiela
Copy link
Copy Markdown
Contributor

Summary

  • remove the internal eas/__maestro_test function registration and implementation
  • delete the Maestro flow/config discovery helper used by that internal path
  • remove the related tests and fixture files for Maestro config parsing and flow resolution

Testing

  • yarn --cwd packages/build-tools typecheck
  • yarn --cwd packages/build-tools jest-unit --runInBand maestroResultParser reportMaestroTestResults easFunctions

@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.36%. Comparing base (c9cdfd1) to head (4499927).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3560      +/-   ##
==========================================
+ Coverage   53.78%   54.36%   +0.58%     
==========================================
  Files         820      822       +2     
  Lines       34965    35107     +142     
  Branches     7276     7259      -17     
==========================================
+ Hits        18802    19081     +279     
+ Misses      16072    15939     -133     
+ Partials       91       87       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela changed the title Remove internal maestro test flow discovery code [build-tools] Remove reuse_devices: false dead code Mar 31, 2026
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Mar 31, 2026
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela requested a review from hSATAC March 31, 2026 08:29
Copy link
Copy Markdown
Contributor

@hSATAC hSATAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I have a linear task for this but you're ahead of me.

@sjchmiela
Copy link
Copy Markdown
Contributor Author

Oh sorry, I didn't know! Thank you for keeping Linear tidy AND working on the other great things in Vancouver!!

@sjchmiela sjchmiela merged commit 8a74758 into main Apr 2, 2026
10 of 11 checks passed
@sjchmiela sjchmiela deleted the stanley/remove-maestro-test-code branch April 2, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants