[eas-cli] Add support for configuring app store connect connection#3558
[eas-cli] Add support for configuring app store connect connection#3558
Conversation
723b913 to
246f469
Compare
246f469 to
3f62741
Compare
3f62741 to
bbf0b21
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
+ Coverage 54.38% 54.53% +0.16%
==========================================
Files 824 829 +5
Lines 35420 35554 +134
Branches 7318 7351 +33
==========================================
+ Hits 19258 19387 +129
- Misses 16075 16079 +4
- Partials 87 88 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bbf0b21 to
ee2dc34
Compare
|
Subscribed to pull request
Generated by CodeMention |
douglowder
left a comment
There was a problem hiding this comment.
Looks good overall. Adding @quinlanj for the review.
| ownerAccount, | ||
| await provideOrGenerateAscApiKeyAsync( | ||
| credentialsContext, | ||
| AppStoreApiKeyPurpose.SUBMISSION_SERVICE |
There was a problem hiding this comment.
add an extra purpose to the enum. also, if you havent already, you should double check the permissions granted to the key is what you guys need for the asc app connection!
There was a problem hiding this comment.
Extended the enum.
As for the permissions granted to the key, the role is ADMIN, which is the full access role. But now I'm wondering if following the principle of least privilege, maybe we should use the APP_MANAGER role 🤔 cc @sjchmiela
|
✅ Thank you for adding the changelog entry! |
Why
We're adding App Store Connect integration support. The UI for configuring such connection is available in the web dashboard, but it would also be useful to have it in the CLI – this is the goal of this PR.
How
connectionsoclif topic.eas connections:asc:status– check the status of the current project's connection.eas connections:asc:connect– go through the process of connecting the current project with an ASC app.eas connections:asc:disconnect– disconnects the current project from the ASC app.Test Plan
Interactive mode testing:
Non-interactive mode: