Skip to content

[eas-build-job] Add app_store_connect event context to WorkflowInterpolationContext#3530

Merged
sswrk merged 3 commits intomainfrom
szymonswierk/eng-20054-add-some-app_store_connect-event-to-workflow-runs-triggered
Apr 1, 2026
Merged

[eas-build-job] Add app_store_connect event context to WorkflowInterpolationContext#3530
sswrk merged 3 commits intomainfrom
szymonswierk/eng-20054-add-some-app_store_connect-event-to-workflow-runs-triggered

Conversation

@sswrk
Copy link
Copy Markdown
Contributor

@sswrk sswrk commented Mar 23, 2026

Why

We're adding support for on.app_store_connect trigger in workflows. We need to enable users to access ASC context. This PR adds a basic schema, with just ASC app ID.

How

Extend StaticWorkflowInterpolationContextZ by adding app_store_connect schema with just event object containing just app, with just the id property.

Test Plan

Added unit test.

@sswrk sswrk requested a review from sjchmiela March 23, 2026 14:35
@sswrk sswrk added the no changelog PR that doesn't require a changelog entry label Mar 23, 2026
@linear
Copy link
Copy Markdown

linear bot commented Mar 23, 2026

@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.29%. Comparing base (9328063) to head (5f83b2e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3530   +/-   ##
=======================================
  Coverage   54.29%   54.29%           
=======================================
  Files         822      822           
  Lines       35324    35324           
  Branches     7307     7307           
=======================================
  Hits        19175    19175           
  Misses      16062    16062           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

I think we can later talk about what we could do to make app_store_connect helpful!

Like, we could load app_store_connect.app that would comprise of preloaded app.attributes and for build-upload-related webhooks we could do app_store_connect.build_upload that would be attributes too, etc.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sswrk sswrk merged commit 26fdf8f into main Apr 1, 2026
10 checks passed
@sswrk sswrk deleted the szymonswierk/eng-20054-add-some-app_store_connect-event-to-workflow-runs-triggered branch April 1, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants